added method to check for closed TwoComplex and TwoComplex with boundary. Soon will add checks for all the methods

siddhartha-gadgil / Superficial

Curves and other structures on surfaces (topology)

MIT License

3 stars 13 forks source link

added method to check for closed TwoComplex and TwoComplex with boundary. Soon will add checks for all the methods #21

Closed anotherArka closed 4 years ago

siddhartha-gadgil commented 4 years ago

Firstly, you mean "closed surface" and "surface with boundary" (everything is a two-complex). More importantly, do you have checks that

each edge is in at most one face
exactly one for the closed case
at least one of e, e.flip is in a face for the case with boundary.
every vertex is in some edge.

siddhartha-gadgil commented 4 years ago

Merging to allow others to use this, but need to address the issues

anotherArka commented 4 years ago

I thought we are already checking these using Assert

On Fri, 31 Jan 2020, 8:22 am Siddhartha Gadgil, notifications@github.com wrote:

Merging to allow others to use this, but need to address the issues

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/siddhartha-gadgil/Superficial/pull/21?email_source=notifications&email_token=AJNDRL4XIEWGC62R6FFVMWDRAOG7BA5CNFSM4KN3YYF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKNKB7Q#issuecomment-580559102, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJNDRL5EVKAYI6NT5TQDLP3RAOG7BANCNFSM4KN3YYFQ .

anotherArka commented 4 years ago

I will add the conditions shortly

On Fri, 31 Jan 2020, 9:02 am Arka Ghosh, arkasparko@gmail.com wrote:

I thought we are already checking these using Assert

On Fri, 31 Jan 2020, 8:22 am Siddhartha Gadgil, notifications@github.com wrote:

Merging to allow others to use this, but need to address the issues

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/siddhartha-gadgil/Superficial/pull/21?email_source=notifications&email_token=AJNDRL4XIEWGC62R6FFVMWDRAOG7BA5CNFSM4KN3YYF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKNKB7Q#issuecomment-580559102, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJNDRL5EVKAYI6NT5TQDLP3RAOG7BANCNFSM4KN3YYFQ .