Issue with SMF Quiz - Githubissues

siddhartha-gupta commented 9 years ago

http://www.simplemachines.org/community/index.php?topic=506743.msg3805811#msg3805811

siddhartha-gupta commented 9 years ago

Not able to reproduce for now

Al-eXs commented 9 years ago

I see that a lot of the issues with the post button not showing are since 5149ab8887ea0a5a18308a50ca8d5b0e1dfba6c0 where introduced, and in most of the themes the issue is that some .js files have an error and then JS functions didn't work well.

Instead of using JS, I think is better just use plain CSS with that in LikePost.css

.like_post_box {
    line-height: 22px;
    position: relative;
}
.stickybg2 .like_post_box {
    margin-right: 30px;
}

and delete this function in LikePosts.js

        lpObj.jQRef('.like_post_box').each(function() {
            if (lpObj.jQRef(this).parent().parent().hasClass('stickybg2')) {
                lpObj.jQRef(this).css({
                    'margin-right': '30px'
                });
            }
            lpObj.jQRef(this).show();
        });

I have this in my production site, the button is shows, in the sticky that have the icon the button have it´s margin, all other things related with this mod works as intended, and the other mods that use jQuery work as well.

siddhartha-gupta commented 9 years ago

Well, for sure we can remove few things from JS and deal them in CSS as you have suggested.

Basically if jQuery is not loaded in that case only like button is not shown. For now I'm adding the CSS margin change and I think https://github.com/siddhartha-gupta/SMF-Likes/commit/f5952b866eafc75d96439c06b96da569bcdc9da7 should take care of a lot of ongoing jQuery loading issue

siddhartha-gupta / SMF-Likes

Issue with SMF Quiz #42