siddharthkp / bundlesize

Keep your bundle size in check
MIT License
4.47k stars 180 forks source link

Using the GitHub App #203

Open gr2m opened 6 years ago

gr2m commented 6 years ago

Hey there,

I found out there is a GitHub App at https://github.com/apps/bundlesize. I was curious and tried to install it on https://github.com/octokit/rest.js but after install it redirected me to https://github.com/login/oauth/authorize?installation_id=91906 which gives me a 404.

I was hoping that using the GitHub App I could use bundlesize on pull requests from forks which currently is not working because I have the token configured on Travis as secret environment variable which are not exposed on builds coming from forks.

If there is anything I can help with on the app, let me know! I’m working on GitHub’s JavaScript toolkit for their APIs as am helping out on https://probot.github.io/, too :)

edmorley commented 6 years ago

Converting to a GitHub app would be very useful for us too, since there are issues with the legacy oauth app permissions model that means our org admins have (understandably, given how broken it is) declined my request for approval (see here).

If there's anything I can help with just shout :-)