search

siddharthkp / bundlesize

Keep your bundle size in check
MIT License
4.47k stars 180 forks source link

Provide proper auth integration for Enterprise users #95

Open Aghassi opened 7 years ago

Aghassi commented 7 years ago

Hello,

I'm looking to use this package with an enterprise deployment of CircleCI. Is there a reason you aren't using the GitHub API to do proper auth and status checks on builds? I don't mind running this as a command post yarn, but I still would like to have the status check if possible on our PRs in GitHub enterprise.

Alternatively, is there a way I could set this to have our Circle job push the status to GitHub based on results this provides?

Looking forward to hearing from you guys. Would be great to have this ability!

siddharthkp commented 7 years ago

Related: https://github.com/siddharthkp/github-build/issues/3

Aghassi commented 7 years ago

@siddharthkp Thanks! If I have bandwidth I can take a crack at that PR, but for right now I used this NPM module to get things up and running: https://www.npmjs.com/package/commit-status

All I did was yarn test - contains bundlesize if [ $? -eq 1 ]; then commit-status failure "Failed bundle check, see logs for details".

Certainly not ideal, but was easy enough to get the job done.