siddharthkp / github-build

Github builds for CI
MIT License
133 stars 7 forks source link

Support for Github enterprise URLs #5

Open rahulgandhi opened 7 years ago

rahulgandhi commented 7 years ago

This PR fixes https://github.com/siddharthkp/github-build/issues/3 and also https://github.com/siddharthkp/bundlesize/issues/95.

I have tested it on my Github enterprise account.

Once we release this, I'll update github-build version on bundlesize

rahulgandhi commented 7 years ago

I think it is failing because I don't have a key for the account the test is written for. The test depends on process.env.github_token which I don't have for this repo.

rahulgandhi commented 7 years ago

@siddharthkp Can you have a look?

jmccann commented 6 years ago

@siddharthkp We gave this patch a try and it seems to be working. Any chances on getting this merged? If you need/want some updates let me know and we can work through it. Thanks!!!!

rahulgandhi commented 6 years ago

I'm up for making any modifications to this PR if needed.