[zsh] Would be great to have 5-8 recent commands listed already

[hamxabaig]

When we type historie in the command line. It'd be great to show list of recent commands say like 5-8 of them. Right now it just shows me to search, leaving me to additional key strokes. ;)

[siddharthkp]

That's how it works on mac 😄

Which OS are you on?

[hamxabaig]

haha, I'm on mac too. I'm using zsh in terminal.

[siddharthkp]

Interesting 🤔

Which terminal are you using?

[hamxabaig]

@siddharthkp zsh.

[hamxabaig]

Thought it'll help.

[siddharthkp]

Hmm,

historie uses sindresorhus/shell-history

Can you check if that works with zsh?

If not, I'll try to implement it.

[hamxabaig]

@siddharthkp shell-history gives me all of the commands that were typed. Its working.

[siddharthkp]

I just tried with zsh, working for me 🙈

Can you help me debug this?

[hamxabaig]

Umm strange. Yeah sure, would love to help.

[hamxabaig]

After typing historie, it gives me nothing (as in screenshot above). But when i try to filter by typing some command name. It actually gives me the list. o.O

[siddharthkp]

Here's the line for the starting case:

https://github.com/siddharthkp/historie/blob/master/history.js#L15

[hamxabaig]

@siddharthkp Sure, I'll check this. Forked 🎉

[willhoney7]

FWIW, I'm using zsh (with ohmyz.sh) and it works properly. Not sure what the cause would be for your case.

[hamxabaig]

@siddharthkp I checked and problem was that hint was empty when typing historie. So filtering commands with empty hint was returning empty choices. I added a check when hint is empty then i just resolve it with recent 8 commands.