Alert component - Githubissues

siddharthkp / react-ui

Customisable components and primitives based on design tokens

https://react-ui.dev/

418 stars 53 forks source link

Alert component #71

Closed siddharthkp closed 4 years ago

siddharthkp commented 4 years ago

[x] Accessible
[x] Add documentation
[x] Add default styles
[x] Add styles for base, light and dark theme
[x] Add customisation docs
[x] Add example in components page

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sid/react-ui/fwrjhbtg3 ✅ Preview: https://react-ui-git-alerts.sid.now.sh

siddharthkp commented 4 years ago

Good point!

I added type description in the docs, but we don't render the description 😅 so it's hidden. something to explore for all components

rubenmoya commented 4 years ago

I added type description in the docs, but we don't render the description 😅 so it's hidden. something to explore for all components

Completely missed it 😱

siddharthkp commented 4 years ago

Added the accessible badge. Props in description is something I'm going to tackle in the Props component