search

siddharthkp / react-ui

Customisable components and primitives based on design tokens
https://react-ui.dev/
418 stars 53 forks source link

Test: remove margin 0 #81

Closed siddharthkp closed 4 years ago

siddharthkp commented 4 years ago

Removing a strong {margin: 0} from styles so that it doesn't override user specified fields because of incorrect order

This might help with https://github.com/siddharthkp/react-ui/pull/51

Visual tests helped to find out there was only 1 component affected - checkbox. Added margin:0 in base styles for that

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sid/react-ui/fi22b5wvd ✅ Preview: https://react-ui-git-test-remove-margin.sid.now.sh

rubenmoya commented 4 years ago

I just discovered Chromatic and I love it 😍