meta tags added for pages

siddharthkp / react-ui

Customisable components and primitives based on design tokens

https://react-ui.dev/

418 stars 53 forks source link

meta tags added for pages #96

Open Avi98 opened 4 years ago

Avi98 commented 4 years ago

Added meta tags for pages fixes #95

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sid/react-ui/ra28yb36h ✅ Preview: https://react-ui-git-fork-avi98-feat-95docs-title-meta-tags.sid.vercel.app

siddharthkp commented 4 years ago

@Avi98 This is the right direction for sure 👍

I tried testing the preview url (generated by vercel in the commment above) on twitter's card validator (https://cards-dev.twitter.com/validator) and it didn't validate. it's probably something very small but

Avi98 commented 4 years ago

@siddharthkp , Facebook and Twitter crawlers don't work on client-side javascript. I need to take a different library like react-snapshot. Should I go ahead with this