siddhi-io / docker-siddhi

Docker resources for Siddhi cloud-native streaming
Apache License 2.0
10 stars 10 forks source link

Enable optional base image settings to Dockerfiles #26

Closed BuddhiWathsala closed 5 years ago

BuddhiWathsala commented 5 years ago

Purpose

To support optional base image selection for runner and tooling Dockerfiles.

Goals

$subject

Approach

User stories

Users can change the docker base image like follow.

For runner images alpine/ubuntu

$ docker build -t siddhiio/siddhi-runner-ubuntu:latest-dev --build-arg SIDDHI_RUNNER_BASE_IMAGE=siddhiio/siddhi-runner-base-ubuntu:latest-dev .

For tooling

$ docker build -t siddhiio/siddhi-tooling:latest-dev --build-arg SIDDHI_TOOLING_BASE_IMAGE=siddhiio/siddhi-tooling-base:latest-dev .

Release note

$subject

Related PRs

https://github.com/siddhi-io/docker-siddhi/pull/23

Test environment

Docker client and server version 19.03.2

Learning

Pass base image as an argument: https://stackoverflow.com/questions/32745416/how-to-dynamically-change-the-dockers-base-image