Add sync and asyncronous committing configurable and bug fix for sending events after siddhi app undeployed - Githubissues

siddhi-io / siddhi-io-kafka

Extension that can be used to receive events from a Kafka cluster and to publish events to a Kafka cluster

https://siddhi-io.github.io/siddhi-io-kafka/

Apache License 2.0

18 stars 50 forks source link

Add sync and asyncronous committing configurable and bug fix for sending events after siddhi app undeployed #126

Closed ramindu90 closed 4 years ago

ramindu90 commented 4 years ago

Purpose

Add parameters to enable/ disable asynchronous committing bug fix for sending events after siddhi app is undeployed

Goals

Enable synchronous as well as asynchronous committing Fix https://github.com/wso2/product-sp/issues/1055#issue-536345895

Approach

Add additional parameter Add a flag not to send after the consumer.close() in the disconnect() function, even if the recent consumer.poll() records have not sent to Streams

Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes
Ran FindSecurityBugs plugin and verified report? yes
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes