siddii / angular-timer

re-usable/inter-operable AngularJS timer directive ⛺
http://siddii.github.io/angular-timer/
MIT License
791 stars 939 forks source link

Can't set timer by code #194

Open joebordes opened 9 years ago

joebordes commented 9 years ago

This questions seems to be raised various times in the issue tracker but I can't get it to work. The timer works fine on first load of the angularjs application but then no matter how I seem to change the binded variable it just does not react.

I create a plunker in hope somebody can tell me what I am doing wrong:

http://plnkr.co/edit/4QeZYsgDcxpkvgUjgHL6?p=preview

thanks

joebordes commented 9 years ago

This change seems to fix the problem for me, but I am really not sure if it is correct:

https://github.com/joebordes/angular-timer/commit/0229d84493c8e47a8e98ab430ad67124327bd92f

if you want a PR, let me know.

siddii commented 9 years ago

Yes, please.

joebordes commented 9 years ago

done