feat: Add httpOnly cookie attribute support

sidebase / nuxt-auth

Authentication built for Nuxt 3! Easily add authentication via OAuth providers, credentials or Email Magic URLs!

https://auth.sidebase.io

MIT License

1.31k stars 164 forks source link

feat: Add httpOnly cookie attribute support #847

Closed maximehamou closed 3 months ago

maximehamou commented 3 months ago

❓ Type of change

[x] 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[x] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Added httpOnly attribute support for local and refresh providers + updated the docs accordingly

📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have added tests (if possible).
[x] I have updated the documentation accordingly.

phoenix-ru commented 3 months ago

@maximehamou Could you please fix lint issues? Aside from that, code lgtm

maximehamou commented 3 months ago

@maximehamou Could you please fix lint issues?

No problem, I will shortly.

However, I think it’s a little bit trickier than expected regarding how the update works. After further tests, the cookie is not saved. If I set httpOnlyCookieAttribute to false, and I force httpOnly with the checkbox in storage section, I couldn't log out anymore...