enh(#797): Determine if `baseUrl` is external and properly handle internal requests - Githubissues

sidebase / nuxt-auth

Authentication built for Nuxt 3! Easily add authentication via OAuth providers, credentials or Email Magic URLs!

https://auth.sidebase.io

MIT License

1.25k stars 162 forks source link

enh(#797): Determine if `baseUrl` is external and properly handle internal requests #856

Closed zoey-kaiser closed 1 week ago

zoey-kaiser commented 1 month ago

🔗 Linked issue

closes #797

❓ Type of change

[ ] 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[X] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR adds a check to determine if the provided baseUrl config entry is an external or internal API route. This check is done by:

1. If the baseURL includes a host
  - If not, then the baseURL is assumed to be an internal Nuxt route
1. if the baseURL host matches the host of the current event.req
  - If a host was added that matches the URL of the application, then requests are handled as internal requests

📝 Checklist

[X] I have linked an issue or discussion.
[ ] I have added tests (if possible).
[x] I have updated the documentation accordingly.

pkg-pr-new[bot] commented 1 month ago

Open in Stackblitz

pnpm add https://pkg.pr.new/@sidebase/nuxt-auth@856

commit: a79cd9b

zoey-kaiser commented 1 week ago

Closing in favour of #913