Setting expiryInSeconds to null has no effect - Githubissues

sidebase / nuxt-session

Nuxt session middleware to get a persistent session per app user, e.g., to store data across multiple requests. The nuxt session module provides the useSession() composable out of the box and sets up API endpoints to interact with your session to make working with sessions feel like a breeze.

https://sidebase.io/nuxt-session/

MIT License

188 stars 19 forks source link

Setting expiryInSeconds to null has no effect #38

Closed interpretor closed 1 year ago

interpretor commented 1 year ago

Environment

Operating System: Linux
Node Version: v18.12.1
Nuxt Version: 3.0.0
Nitro Version: 1.0.0
Package Manager: npm@8.19.2
Builder: vite
User Config: runtimeConfig, nitro, modules, build, session
Runtime Modules: @nuxtjs/tailwindcss@6.1.3, @sidebase/nuxt-session@0.2.5
Build Modules: -

Reproduction

No response

Describe the bug

In nuxt.config.ts set session.session.expiryInSeconds to null
Start the nuxt application
The moduleOptions in ModuleDefinition<ModuleOptions>.setup will be the default value of 600

Setting expiryInSeconds to another value other than null just works fine.

Additional context

No response

Logs

No response

interpretor commented 1 year ago

Properties with null values aren't copied by defu. As mentioned here, we would need to exchange defu with another module which doesn't ignore null, or change the expiryInSeconds option to use false instead of null.

@BracketJohn What's your opinion?