search

sideeffects / HoudiniEngineForUnreal-v2

Houdini Engine Plugin for Unreal Engine 4 - Version 2
http://www.sidefx.com/unreal
Other
295 stars 75 forks source link

HoudiniEngine.Build.cs log spam #16

Closed Ryan-DowlingSoka closed 3 years ago

Ryan-DowlingSoka commented 4 years ago

Edited/Revised:

We have been attempting to reduce log spam across our projects, and have noticed some warning/info spam related to Houdini not being installed (or even if it is installed, still get some spam.)

For reference:

Binding IntelliSense data... 0%Houdini Engine : Looking for Houdini Engine 18.0.460 in C:/Program Files/Side Effects Sof
tware/Houdini Engine 18.0.460
Houdini Engine : Looking for Houdini 18.0.460 in C:/Program Files/Side Effects Software/Houdini 18.0.460
Houdini Engine : Failed to find Houdini 18.0.460, will attempt to build using the latest installed version
Houdini Engine : Please install Houdini or Houdini Engine 18.0.460
Houdini Engine : Looking for Houdini Engine 18.0.460 in C:/Program Files/Side Effects Software/Houdini Engine 18.0.460
Houdini Engine : Looking for Houdini 18.0.460 in C:/Program Files/Side Effects Software/Houdini 18.0.460
Houdini Engine : Failed to find Houdini 18.0.460, will attempt to build using the latest installed version
Houdini Engine : Please install Houdini or Houdini Engine 18.0.460
81%Houdini Engine : Looking for Houdini Engine 18.0.460 in C:/Program Files/Side Effects Software/Houdini Engine 18.0.46
0
Houdini Engine : Looking for Houdini 18.0.460 in C:/Program Files/Side Effects Software/Houdini 18.0.460
Houdini Engine : Failed to find Houdini 18.0.460, will attempt to build using the latest installed version
Houdini Engine : Please install Houdini or Houdini Engine 18.0.460
100%

We have locally replaced the system.console writes with the Tools.DotNetCommon.Log Trace system Unreal Build Tool uses elsewhere.

We'd love to have this brought back into the repo so that we don't need to maintain it through integrations. Is this something you could take back? I would do a pull request, but I can't fork, and I don't know github well enough to know if there is a better way to send this to you.

Here is our version to diff in a .zip: HoudiniEngine.Build.zip

dpernuit commented 4 years ago

Hi Ryan,

Thank you for that, I'll have a look at your changes and will let you know. I don't think there is a better way to send me changes for now, with the repo being private / read-only, I don't think there's a way for you to submit PR.

I do agree that currently, the logs are a bit spammy. We probably shouldn't log anything if the desired version of H is found, and should only log the error/info once in case we don't.

Ryan-DowlingSoka commented 4 years ago

Thanks, good to know.

As I mentioned on our call there is a crash in my version on the final Log.TraceError. It should be:

Log.TraceInformationOnce(log)

Cheers.

Ryan-DowlingSoka commented 3 years ago

Fixed in: c4991fa