search

sideeffects / HoudiniEngineForUnreal-v2

Houdini Engine Plugin for Unreal Engine 4 - Version 2
http://www.sidefx.com/unreal
Other
295 stars 75 forks source link

Remove the 'HoudiniEngine' folder for easier submodule linkage #2

Closed Kalmalyzer closed 4 years ago

Kalmalyzer commented 4 years ago

I suggest that you move the plugin out of the HoudiniEngine subfolder and into the root of this repository.

For people who use VCSes that support sub-repositories (Git & Plastic SCM, but not Perforce), and let everyone on the team build everything from source, it is nice to be able to link the HoudiniEngineForUnreal-v2 repository as a whole into a submodule folder at <game project>/Plugins/Runtime/HoudiniEngine -- without doing any local changes, such as extracting the contents of a subfolder.

With the current directory layout, that strategy will always end up with a folder structure like <game project>/Plugins/Runtime/HoudiniEngine/HoudiniEngine. If you were to move the unreal plugin itself straight into the root of this repository, you would provide an appropriate folder structure for those use cases as-is.

dpernuit commented 4 years ago

Fixed - that's also how the v1 repo was setup.

Kalmalyzer commented 4 years ago

Thanks - you probably want to change the sentence in the readme as well:

Extract the "HoudiniEngine" folder in the release to the "Plugins/Runtime" folder of Unreal. You can install the plugin either directly in the engine folder (in "Engine/Plugins/Runtime/HoudiniEngine") or in your project folder (in "Plugins/Runtime/HoudiniEngine").

dpernuit commented 4 years ago

Not needed, the release zip does contain a HoudiniEngine folder.