sideeffects / HoudiniEngineForUnreal

Houdini Engine Plugin for Unreal Engine.
http://www.sidefx.com/unreal
Other
1.32k stars 370 forks source link

Fix Nanite FallbackPercentTriangles param being copied from the wrong attribute #172

Closed Filoppi closed 2 years ago

Filoppi commented 2 years ago

It seems like a copy and paste error. I've changed FallbackPercentTriangles to use the engine default of 1, otherwise any imported mesh that uses Nanite will NOT have any collisions in the physics engine when doing complex collision queries, as the complex physics scene would have a collision mesh with no vertices for that static mesh.

You might also want to expose FMeshNaniteSettings::FallbackRelativeError as with the default value of 1, more complex meshes are simplified to a fallback mesh with massive holes in them, so we manually need to set it back to 0 on some meshes. Though this is more of an engine issue.

dpernuit commented 2 years ago

Thanks for bringing this up. This PR has been merged on our end and is now available on the git repo. I also added support for setting FallbackRelativeError and TrimRelativeError via attributes.