Fix incorrect use of conversion macros, caught by Linux build (clang)

sideeffects / HoudiniEngineForUnreal

Houdini Engine Plugin for Unreal Engine.

http://www.sidefx.com/unreal

Other

1.31k stars 368 forks source link

Fix incorrect use of conversion macros, caught by Linux build (clang) #249

Closed kristjanvalur closed 1 year ago

kristjanvalur commented 1 year ago

The TCHAR_TO_ANSI style macros must not be used like this. They can only be used directly for arguments to function calls, etc. To assign a pointer to the converted value, an intermediate conversion variable must be used.

Found by cross-compiling for Linux using Clang

dpernuit commented 1 year ago

Hi, Yes, thanks for bringing those up! I did a pass recently on those, but it seems that I missed a couple! PR merge on our end, it will be in tomorrow's daily build.