Missing WITH_EDITOR guard for material functions.

sideeffects / HoudiniEngineForUnreal

Houdini Engine Plugin for Unreal Engine.

http://www.sidefx.com/unreal

Other

1.36k stars 374 forks source link

Missing WITH_EDITOR guard for material functions. #37

Closed JaapSuter closed 8 years ago

JaapSuter commented 8 years ago

Should these functions near lines 269 to 298 in HoudiniEngineUtils.h be wrapped in a WITH_EDITOR (and correspondingly so in the .cpp file)

    CreateMaterialComponentDiffuse
    CreateMaterialComponentNormal
    CreateMaterialComponentSpecular
    CreateMaterialComponentRoughness
    CreateMaterialComponentMetallic
    CreateMaterialComponentEmissive
    CreateMaterialComponentOpacity

Otherwise I'll get a build error in my non-editor builds because FHoudiniEngineUtils::CreateUnrealTexture isn't available.

Thanks!

ttvd commented 8 years ago

Good catch! Will commit a fix ASAP.

ttvd commented 8 years ago

This bug should be fixed in:

H15.0/390 (Feb 18, 2016).

ttvd commented 8 years ago

h15_246083.diff.txt

(diff file for H15 branches if you need it in the meantime)

JaapSuter commented 8 years ago

Faster than light, thanks!