Closed anoxdetox closed 2 years ago
Hi,
The latest code from the UE4.27 branch (https://github.com/sideeffects/HoudiniNiagara/tree/UE4.27) should build, yes. You can also grab the source + binaries from the release, for convenience: https://github.com/sideeffects/HoudiniNiagara/releases/tag/v2.2.0-UE4.27.
Isn't this actually a bug?
From NiagaraDataInterface.h
:
#if WITH_EDITORONLY_DATA
/** Allows data interfaces to provide common functionality that will be shared across interfaces on that type. */
virtual void GetCommonHLSL(FString& OutHLSL)
{
}
virtual void GetParameterDefinitionHLSL(const FNiagaraDataInterfaceGPUParamInfo& ParamInfo, FString& OutHLSL)
{
}
virtual bool GetFunctionHLSL(const FNiagaraDataInterfaceGPUParamInfo& ParamInfo, const FNiagaraDataInterfaceGeneratedFunction& FunctionInfo, int FunctionInstanceIndex, FString& OutHLSL)
{
return false;
}
/**
Allows data interfaces the opportunity to rename / change the function signature and perform an upgrade.
Return true if the signature was modified and we need to refresh the pins / name, etc.
*/
virtual bool UpgradeFunctionCall(FNiagaraFunctionSignature& FunctionSignature)
{
return false;
}
#endif
These functions doesn't exist when packaging, which causes the build to fail because the plugin assume they do.
Putting GetFunctionHLSL
, GetParameterDefinitionHLSL
and GetCommonHLSL
functions in #if WITH_EDITORONLY_DATA
clauses solved my build error when packaging.
If you consider this a bug I can make a pull request.
Thanks for PR! Merged and fixed :).
I have been trying to build from source using UAT and 4.27.0. Is it possible to do so?
Here is what I am getting... Thanks