sidekickcode / sidekick

:+1: Your code, made perfect :rocket:
16 stars 3 forks source link

"sidekick run --ci": The keyword 'const' is reserved #2

Open sagarpatke opened 7 years ago

sagarpatke commented 7 years ago

.eslintrc.js:

module.exports = {
...
  "env": {
    ...
    "es6": true
  }
...
  "ecmaFeatures": {
    ...
    "blockBindings": true
    ...
  }
...
}

However, gulp-eslint plugin doesn't report any errors in the project with the same eslint configuration.

rishson commented 7 years ago

Hi @sagarpatke . In your eslint config, you need to specify es6 in the parserOptions:

{
  "parserOptions": {
    "ecmaVersion": 6
  },
}

Let me know if that works for you.

sagarpatke commented 7 years ago

Hi @rishson, I tried that, but the error still persists. I tried this with both the babel-eslint, and espree parsers.

rishson commented 7 years ago

@sagarpatke can you post your eslint config please so I can create a test case around it?

sagarpatke commented 7 years ago

https://github.com/sagarpatke/react-boilerplate/blob/master/.eslintrc.js