search

sidekickcode / sidekick

:+1: Your code, made perfect :rocket:
16 stars 3 forks source link

Updated dependencies to latest. #5

Closed nagapavan closed 6 years ago

nagapavan commented 6 years ago

Fixed test cases to address dependency update

rishson commented 6 years ago

@nagapavan are you wanting to merge these changes into your own fork of this repo instead?

nagapavan commented 6 years ago

@rishson I am trying to merge changes to this repo. For some reason build is failing at sidekick evaluation, I was trying to debug. If possible, can you or one of the team help me with merging the changes?

rishson commented 6 years ago

@nagapavan thanks for your interest in sidekick.

Typically, for this project, the process is:

Is this how you have worked with other projects?

nagapavan commented 6 years ago

@rishson My apologies for rushing and not following the process. Yes, I did follow the process in other project. Somehow I got distracted and directly jumped to the PR.

Closing this thread to start-off cleanly. My apologies once again.