sideroad / grunt-testem

Execute testem with Continuous Integration Mode then generate TAP file as test results.
41 stars 10 forks source link

testem version changed in grunt-testem@0.5.5 without updating grunt-testem version #22

Open jblack10101 opened 9 years ago

jblack10101 commented 9 years ago

I've got a project that uses grunt-testem@0.5.5. Recently, my grunt tasks that use Testem started failing for seemingly no reason. I spent a lot of time troubleshooting the issue, and I found that some of my node packages' transitive dependencies changed without the main packages updating their version numbers.

When my builds were working, grunt-testem@0.5.5 depended ontestem@0.6.19. When my builds started failing, grunt-testem@0.5.5 now depends on testem@0.6.39.

So in the future, please reference an exact version number in your package.json, and update your node module's version number when your dependency versions update. Thanks

jblack10101 commented 9 years ago

Well, I'm going to just start using shrinkwrap, so disregard my request above.

But I think I found the issue: My tests are hanging when I define an output.coverage option to use with grunt-istanbul. It worked with grunt-testem@0.5.5 was pulling in testem@0.6.19, and now fails when it pulls in testem@0.6.39.

Here's a snippet of my grunt config:

grunt.initConfig({
    ...
    testem: {
        options: {
            launch_in_ci: ["Chrome"],
            output: {
                coverage: 'tmp/coverage/from_browsers/'
            },
            routes: {
                "/build": "instrumented/build"
            },
            force: false,
            port: testemPort
        },
        main: {
            src: [
                ...             
            ],
        },
        ...
    },
    ...
});

If I remove the testem.options.output object, it works with the latest version of testem, otherwise it hangs.

yvanavermaet commented 9 years ago

I created a ticket for this issue about an hour ago. In my opinion this is an issue with testem, not with grunt-testem or gulp-testem (in my case): https://github.com/airportyh/testem/issues/500

sideroad commented 9 years ago

denk> thanks for creating the ticket.

jblack> sorry for inconvinient...

I hope that testem community will resolve this issue.

yvanavermaet commented 9 years ago

@sideroad @jblack10101 A quick fix was added to the testem-multi module (which is used by the grunt-testem module). testem-multi module will use 0.6.24 (instead of 0.6.39), which doesn't have this issue. So re-install the node modules.