siderolabs / cluster-api-bootstrap-provider-talos

A cluster-api bootstrap provider for deploying Talos clusters.
https://www.talos-systems.com
Mozilla Public License 2.0
103 stars 27 forks source link

feat: make `talosconfig` and `talosconfigtemplate` immutable #146

Closed Unix4ever closed 2 years ago

Unix4ever commented 2 years ago

This change is made to conform CAPI practices for resource updates: instead of modifying the templates/configs, it is necessary to create a new one.

If the resource is always recreated, rolling update strategy will be able to pick up the change and redeploy machines.

Signed-off-by: Artem Chernyshev artem.chernyshev@talos-systems.com

frezbo commented 2 years ago

does this mean the retrieved talosconfig becomes invalid on updates?

smira commented 2 years ago

does this mean the retrieved talosconfig becomes invalid on updates?

TalosConfig resource is what controls generation of Talos machine configuration, generated client talosconfig is stored as a per-cluster secret

Unix4ever commented 2 years ago

/m