search

siderolabs / cluster-api-bootstrap-provider-talos

A cluster-api bootstrap provider for deploying Talos clusters.
https://www.talos-systems.com
Mozilla Public License 2.0
103 stars 27 forks source link

fix: add metrics port to manager container #178

Closed UnstoppableMango closed 9 months ago

UnstoppableMango commented 11 months ago

The controller-manager-metrics-service expects an https port on the container to expose

smira commented 11 months ago

I think this seems to be broken either way, as the metric bind addr is localhost, and I don't think it's exposed over https actually (probably http?).

UnstoppableMango commented 11 months ago

Thanks I'll take a look

UnstoppableMango commented 10 months ago

Ok, sorry for the delay. Got some time to look at this again. You're right, binding to localhost seems to be the issue, nothing to do with https.

I updated the port name to maybe make it more clear what the intent is.

Do these changes align with the intended usage for metrics? I don't actually use them at the moment in my environment, I just deploy with Pulumi and by default it waits for services to get endpoints.

smira commented 9 months ago

sorry for ignoring this, with 0.6.3 CABPT moved to new CAPI version, and it has overhauled metrics support