search

siderolabs / cluster-api-bootstrap-provider-talos

A cluster-api bootstrap provider for deploying Talos clusters.
https://www.talos-systems.com
Mozilla Public License 2.0
103 stars 27 forks source link

feat: support for strategic merge patches #189

Closed ksawio97 closed 4 months ago

ksawio97 commented 7 months ago

This commit implements strategic merge patch by reusing talos StrategicMergePatch implementation. Additionally, it adds an integration test for strategic merge patches.

Fixes https://github.com/siderolabs/cluster-api-bootstrap-provider-talos/issues/181.

yoctozepto commented 6 months ago

@smira This is our take at issue #181 that I discussed with you a while ago. I think it will be good to go once my review comments are fixed. Please let us know if there are any further steps.

yoctozepto commented 6 months ago

Almost there - you need to fix the small typo in the commit message and add the sign-off (as git commit -s does) to it.

yoctozepto commented 6 months ago

BTW, you can update also the PR title and details as they are off now (they initially copied from the commits originally proposed for the PR).

smira commented 4 months ago

/ok-to-test

smira commented 4 months ago

/m