Closed Unix4ever closed 2 years ago
Some infra providers (like Hetzner) do not set InternalIPs in the Machine resource. We may need to have a fallback in the provider which will pick ExternalIPs if no InternalIPs were found on any of the nodes.
Machine
This logic should be updated: https://github.com/siderolabs/cluster-api-control-plane-provider-talos/blob/master/controllers/taloscontrolplane_controller.go#L411
+1 for this.
@Unix4ever Would you prefer: A)
or B)
Current logic is that it checks if any of machines do not have InternalIP set. It should remain the same, so the idea will be:
Some infra providers (like Hetzner) do not set InternalIPs in the
Machine
resource. We may need to have a fallback in the provider which will pick ExternalIPs if no InternalIPs were found on any of the nodes.This logic should be updated: https://github.com/siderolabs/cluster-api-control-plane-provider-talos/blob/master/controllers/taloscontrolplane_controller.go#L411