search

siderolabs / cluster-api-control-plane-provider-talos

A control plane provider for CAPI + Talos
Mozilla Public License 2.0
60 stars 20 forks source link

fix: fallback to ExternalIP for bootstrap if no InternalIP is found for the machine #131

Closed damdo closed 2 years ago

damdo commented 2 years ago

Closes https://github.com/siderolabs/cluster-api-control-plane-provider-talos/issues/130

Unix4ever commented 2 years ago

/ok-to-test

Unix4ever commented 2 years ago

gpg identity failing is fine. The PR will need to be signed by someone from Sidero members (will do that when the build succeeds).

smira commented 2 years ago

@Unix4ever tests passed, I will leave it up to you for the final decision

Unix4ever commented 2 years ago

/m