search

siderolabs / cluster-api-control-plane-provider-talos

A control plane provider for CAPI + Talos
Mozilla Public License 2.0
56 stars 19 forks source link

feat: trigger rollout on controlPlaneConfig changes #154

Closed Preisschild closed 1 year ago

Preisschild commented 1 year ago

This change automatically rolls out new Machines when the controlPlaneConfig has been changed.

smira commented 1 year ago

I got detached from this controller for a long time, so I don't remember details. @Unix4ever do you remember why we limited automatic rollouts to what it is right now?

Unix4ever commented 1 year ago

I got detached from this controller for a long time, so I don't remember details. @Unix4ever do you remember why we limited automatic rollouts to what it is right now?

I think the idea behind it was to follow CAPI scheme: you create a new machine template, which is mapped to a new machine config, then flip the machine template version on the control plane resource and as the template version doesn't match it will trigger rollout.

Preisschild commented 1 year ago

FWIW: The Kubeadm reference implementation does behave the same

https://github.com/kubernetes-sigs/cluster-api/blob/main/controlplane/kubeadm/internal/filters.go#L93

Unix4ever commented 1 year ago

FWIW: The Kubeadm reference implementation does behave the same

https://github.com/kubernetes-sigs/cluster-api/blob/main/controlplane/kubeadm/internal/filters.go#L93

Yeah. Ok I don't see a reason why not to merge this change then :)

Preisschild commented 1 year ago

One check is failing due to the commit not having a GPG sig. Is this required? Is there anything else left for me to do?

smira commented 1 year ago

/ok-to-test

smira commented 1 year ago

One check is failing due to the commit not having a GPG sig. Is this required? Is there anything else left for me to do?

should be good now, thank you. we will re-sign your commit before merging

Unix4ever commented 1 year ago

/m