siderolabs / cluster-api-control-plane-provider-talos

A control plane provider for CAPI + Talos
Mozilla Public License 2.0
56 stars 19 forks source link

V0.5.2 breaks backwards compatibility with older machine configs #177

Open AlvesAlexander opened 11 months ago

AlvesAlexander commented 11 months ago

Bug Report

Description

When spinning up clusters with talos version <1.5.0 and provider version 0.5.2 the below error is seen in the sidero controller manager and the node is unable to pull a machine config. downgrading to 0.5.1 the node is able to pull its machine config as intended.

Logs

2023/08/19 05:04:23 failure creating config struct: unknown keys found during decoding: machine: features: diskQuotaSupport: true

Environment

smira commented 11 months ago

CACPPT doesn't generate the machine configuration for Talos, it's the job of CABPT.

In turn, CABPT relies on talosVersion: field to keep the proper compatibility for older versions of Talos.

So this field should be set to match a proper release series of Talos, e.g. v1.4. If not set, or set to ahead of Talos version, the error like above will happen.