feat: get rid of init nodes and use bootstrap API to setup cluster

siderolabs / cluster-api-control-plane-provider-talos

A control plane provider for CAPI + Talos

Mozilla Public License 2.0

62 stars 20 forks source link

Closed Unix4ever closed 2 years ago

Unix4ever commented 2 years ago

That required couple changes in the manager flow:

no longer get node IPs using kubectl get nodes, but use machines addresses instead.
add MachinesBootstrapped condition that means that bootstrap was called on one of the machines.

Unix4ever commented 2 years ago

/approve

smira commented 2 years ago

no longer get node IPs using kubectl get nodes, but use machines addresses instead.

This is going to break Sidero :'(

As Sidero doesn't publish Addresses to the Machines, we can't bootstrap?

Unix4ever commented 2 years ago

This is going to break Sidero :'(

As Sidero doesn't publish Addresses to the Machines, we can't bootstrap?

Yeah, it's chicken and egg problem.

So I guess we'll have to fix Sidero first.

smira commented 2 years ago

we could probably even merge this for v1beta1 and then release Sidero v1beta1 once it has addresses in the Machine

Unix4ever commented 2 years ago

/m --ff