siderolabs / cluster-api-provider-talos

A cluster-api provider for deploying Talos clusters.
https://www.talos-systems.com
Mozilla Public License 2.0
9 stars 4 forks source link

fix: send network devices as nil when marhalling yaml #30

Closed rsmitty closed 5 years ago

rsmitty commented 5 years ago

This PR is necessary to fix a bug where dhcp wasn't getting started on worker nodes. We added omitempty to the network structs that get marshalled up into userdata, which appears to have allowed dhcp to work as expected.

PR will depend on a successful run of conformance tests.

rsmitty commented 5 years ago

Conformance was able to finish with DHCP being online! Merging.