fix: change check_jira regexp

siderolabs / conform

Policy enforcement for your pipelines.

Mozilla Public License 2.0

432 stars 45 forks source link

fix: change check_jira regexp #198

Closed Isakofff closed 3 years ago

Isakofff commented 3 years ago

By default, JIra project key must be at least 2 characters long and contain only uppercase letters. https://confluence.atlassian.com/adminjiraserver/editing-a-project-key-938847080.html

Fixes #197

Signed-off-by: Anton Isakov anton.isakov@dowjones.com

Isakofff commented 3 years ago

Also, I believe there is an option to put regexp in the config. In such a case, each team will have the opportunity to configure such things by themselves.

andrewrynhard commented 3 years ago

Also, I believe there is an option to put regexp in the config. In such a case, each team will have the opportunity to configure such things by themselves.

I actually really like this idea. It would be a Swiss army knife in that case (not just for Jira) and we could make it a generic option in the config.

andrewrynhard commented 3 years ago

/approve

Isakofff commented 3 years ago

How can we re-run 'continuous-integration/drone/pr'? Locally I don't have any issue with 'make test'

andrewrynhard commented 3 years ago

How can we re-run 'continuous-integration/drone/pr'?

Locally I don't have any issue with 'make test'

We need to look into that. We can merge for now.

andrewrynhard commented 3 years ago

/lgtm