search

siderolabs / conform

Policy enforcement for your pipelines.
Mozilla Public License 2.0
432 stars 45 forks source link

fix: update number of regex groups in internal/policy/commit/commit.go #204

Closed dsmcfarl closed 3 years ago

dsmcfarl commented 3 years ago

Commit c23e2fc added "!" for breaking change support to the HeaderRegex in internal/policy/commit/check_conventional_commit.go but did not update the number of regex match groups in internal/policy/commit/commit.go. This change updates the number of groups from 6 to 7 in this file.

andrewrynhard commented 3 years ago

/approve

andrewrynhard commented 3 years ago

@dsmcfarl Looks like you need to amend the commit with the -s flag.

dsmcfarl commented 3 years ago

@andrewrynhard updated with sign-off.

smira commented 3 years ago

I'm sorry that PR got stuck in the review phase, I had same fix re-done in #206 and only then I saw this PR. Closing this as #206 is merged now