search

siderolabs / conform

Policy enforcement for your pipelines.
Mozilla Public License 2.0
432 stars 45 forks source link

fix: update jira issue valid message #214

Closed tylerdave closed 2 years ago

tylerdave commented 2 years ago

Currently when the Jira issue check passes it responds with Jira issues are invalid. This updates the check to return the expected message.

smira commented 2 years ago

@tylerdave your PR looks good, but can you please re-push it with the DCO (git commit --amend -s) and non-empty body?

smira commented 2 years ago

/approve

tylerdave commented 2 years ago

@smira updated! Suppose I should have checked the conform output 😬 . Do you require the GPG signature? I don't have it set up currently but could if necessary.

smira commented 2 years ago

@smira updated! Suppose I should have checked the conform output grimacing . Do you require the GPG signature? I don't have it set up currently but could if necessary.

it anyway requires signature coming from our organization (supply chain security), so I'm going to re-sign your commit and push it back, thanks!

smira commented 2 years ago

/m --ff