siderolabs / image-factory

A service to generate Talos boot assets
Mozilla Public License 2.0
60 stars 16 forks source link

image-factory does not honor extra kernel arguments when secure boot is disabled #134

Closed mattiascockburn closed 2 months ago

mattiascockburn commented 2 months ago

We have the issue that we are not able to preserve our custom kernel arguments when upgrading or even installing (ISO) Talos onto a host. Is there a specific reason why this functionality is disabled or could we change this behaviour somehow?

https://github.com/siderolabs/image-factory/blob/8b4e0d9e9819c7d4c8a533198bed167d56950035/internal/profile/profile_test.go#L539

Our use case requires setting custom kernel args like setting proxies and what not. We can see that the Talos installer itself is preserving some arguments from the running system but not all of them. How may we proceed here?

https://github.com/siderolabs/talos/blob/fd54dc191d06305d7b5fbfe71cd937e7f95d4f10/internal/pkg/install/install.go#L180