search

siderolabs / kubelet

This is a repo for our docker image of the kubelet binary.
9 stars 10 forks source link

Add iscsiadm wrapper #74

Closed sbogomolov closed 1 year ago

sbogomolov commented 1 year ago

In order to create an iscsi PV, kubelet needs access to iscsiadm. Similar trick is described in Talos documentation here.

sbogomolov commented 1 year ago

@frezbo Do I need to get a GPG key and sign the DCO? How do I sign it?

frezbo commented 1 year ago

@frezbo Do I need to get a GPG key and sign the DCO? How do I sign it?

you can ignore the gpg check, we'll re-sign the commit.

For the DCO, you can do a git commit -s --amend --no-edit and a git push --force-with-lease

frezbo commented 1 year ago

/ok-to-test

frezbo commented 1 year ago

/m

frezbo commented 1 year ago

This should be available in newer versions of kubelet we tag.

sbogomolov commented 1 year ago

Awesome, thanks.