siderolabs / kubelet

This is a repo for our docker image of the kubelet binary.
9 stars 10 forks source link

feat: add slim image #84

Closed sergelogvinov closed 2 months ago

sergelogvinov commented 2 months ago

78

Build two images full size and slim.

ghcr.io/sergelogvinov/kubelet   v1.31.0-rc.1-slim   c925dc6995c0   20 minutes ago   211MB
ghcr.io/sergelogvinov/kubelet   v1.31.0-rc.1        c129faaaf339   21 minutes ago   411MB

What do you think to build two images?

smira commented 2 months ago

Yes, I think reducing kubelet image size is a great step forward.

With Kubernetes removing in-tree CSI drivers, I'm not sure if e.g. ceph-common makes any sense for modern kubelet (i.e. 1.31+).

But your PR might be a good way forward to first introduce -slim images, get them tested and start removing stuff from default images.

smira commented 2 months ago

Some refs:

smira commented 2 months ago

I will refactor this a bit to support what we've discussed so far

smira commented 2 months ago

@frezbo @sergelogvinov please let me know what do you think about the changes I made (in a separate commit)

sergelogvinov commented 2 months ago

/lgtm Thanks )

smira commented 2 months ago

/m