siderolabs / omni

SaaS-simple deployment of Kubernetes - on your own hardware.
Other
525 stars 31 forks source link

feat: implement the UI for adjusting machine sets update strategies #229

Closed Unix4ever closed 4 months ago

Unix4ever commented 4 months ago

Allow setting update and delete strategies along with max parallelism.

Fixes: https://github.com/siderolabs/omni/issues/27

Unix4ever commented 4 months ago

https://github.com/siderolabs/omni/assets/830532/e408c9c7-91da-40f0-98e8-10f48c4bc69d

rothgar commented 4 months ago

You may want to validate updates to control plane does not cause etcd instability (eg if 3 nodes only allow 1 node rolling).

For worker nodes a percentage is sometimes better than hard coded rolling because if the cluster scales up (eg 300+ nodes) 5 nodes would still take a long time. IIRC EKS we would allow both settings (hard coded or percentage) and favored the larger one.

Unix4ever commented 4 months ago

We don't allow changing this config for control planes, so that's already validated :) For control planes it's always Rolling and 1 node at a time.

smira commented 4 months ago

Should the Unset be something like "All at the same time" ? idk...

Unix4ever commented 4 months ago

/m