search

siderolabs / omni

SaaS-simple deployment of Kubernetes - on your own hardware.
Other
395 stars 23 forks source link

fix: pass through the `talosctl -n` args if they cannot be resolved #330

Closed utkuozdemir closed 3 weeks ago

utkuozdemir commented 3 weeks ago

We were not correctly checking if the nodes passed via talosctl --nodes were resolved before replacing the target in the GRPC metadata with the resolved ones.

We were handling a single node in the metadata correctly, but not doing the same handing for multiple nodes. This PR fixes that.

Unix4ever commented 3 weeks ago

Can we get some unit tests implemented for it?

I see we have some tests, but could be cool to verify that we no longer have the bug we're trying to fix

utkuozdemir commented 3 weeks ago

Can we get some unit tests implemented for it?

I see we have some tests, but could be cool to verify that we no longer have the bug we're trying to fix

Agreed, done.

utkuozdemir commented 3 weeks ago

/m