siderolabs / omni

SaaS-simple deployment of Kubernetes - on your own hardware.
Other
395 stars 24 forks source link

[bug] Show Descriptions does not do anything in Download Installation Media dialog #380

Closed brantgurga closed 1 week ago

brantgurga commented 1 week ago

Is there an existing issue for this?

Current Behavior

The "Show Descriptions" checkbox in the Download Installation Media dialog does not appear to do anything. image

Expected Behavior

This toggles an optionally visible column describing the available extensions.

Steps To Reproduce

  1. Click the Download Installation Media button on the Omni dashboard. image
  2. Click the "Show Descriptions" checkbox in the Download Installation Media dialog.

What browsers are you seeing the problem on?

Microsoft Edge

Anything else?

Relevant code seems to be at https://github.com/siderolabs/omni/blob/main/frontend/src/views/omni/Modals/DownloadInstallationMedia.vue where indeed all that checkbox is currently doing is changing the state of a variable that nothing appears to look at. Looks like there is code in the Extension Picker that appears to try to do what I expected and show an optional description column for the extensions. https://github.com/siderolabs/omni/blob/main/frontend/src/views/omni/Extensions/ExtensionsPicker.vue I do see descriptions in the response to https://wheatonvanlines.omni.siderolabs.io/api/omni.resources.ResourceService/Watch regarding available extensions. So on the surface, it looks like this is implemented but some UI refresh isn't happening/working. I'll do some followup testing in other browsers and see if this is working elsewhere.

brantgurga commented 1 week ago

I subsequently tried this in Chrome and Firefox and the Description column is not toggling when the Show Descriptions checkbox is toggled.