siderolabs / pkgs

Mozilla Public License 2.0
31 stars 104 forks source link

Add multipath-tools #124

Open andrewrynhard opened 4 years ago

kvaps commented 1 year ago

Heya @andrewrynhard! I wish to enable dm-thin-pool (LVM thin) module for linstor. And I'm looking for the best way to do this.

What do you think about enabling all those CONFIG_DM_THIN_PROVISIONING, CONFIG_DM_MULTIPATH, CONFIG_DM_CACHE and pack ko's into separate device-mapper-pkg?

https://github.com/siderolabs/pkgs/blob/d0eaedcb5cd2510925e4609369e25c3e3572d5fe/kernel/build/config-amd64#L2258-L2284

frezbo commented 1 year ago

Heya @andrewrynhard! I wish to enable dm-thin-pool (LVM thin) module for linstor. And I'm looking for the best way to do this.

What do you think about enabling all those CONFIG_DM_THIN_PROVISIONING, CONFIG_DM_MULTIPATH, CONFIG_DM_CACHE and pack ko's into separate device-mapper-pkg?

https://github.com/siderolabs/pkgs/blob/d0eaedcb5cd2510925e4609369e25c3e3572d5fe/kernel/build/config-amd64#L2258-L2284

Yes extra packages loadable as extensions are welcome

bernardgut commented 4 months ago

@kvaps did you manage to make this work ? I have been successfully testing Talos/Linstor on LVM, ZFS and ZFSTHIN for a couple of weeks now, but I couldn't make LVMTHIN work OOB. Either through the operator :

Error message:                      Failed to create lvm volume

ErrorContext:
  Details:     Command 'lvcreate --config 'devices { filter=['"'"'a|/dev/sdb|'"'"','"'"'r|.*|'"'"'] }' -l 100%FREE -T -n vg1/thin' returned with exitcode 3. 

Standard out: 

Error message: 
modprobe: FATAL: Module dm-thin-pool not found in directory /lib/modules/6.6.28-talos
  /sbin/modprobe failed: 1
  thin-pool: Required device-mapper target(s) not detected in your kernel.
  Run `lvcreate --help' for more information.

Or manually (modified node-shell) :

/ # lvm lvcreate -v --config 'devices { filter=['"'"'a|/dev/sdb|'"'"','"'"'r|.*|'"'"'] }' -l 100%FREE -T -n vg1/thin
  Reloading config files
  Executing: /toolchain/bin/modprobe dm-thin-pool
  /toolchain/bin/modprobe: execvp failed: No such file or directory
  /toolchain/bin/modprobe failed: 2
  thin-pool: Required device-mapper target(s) not detected in your kernel.
  Reloading config files
  Run `lvcreate --help' for more information.
/ # modprobe dm-thin-pool
modprobe: can't load module dm_bio_prison (kernel/drivers/md/dm-bio-prison.ko): Operation not permitted
kvaps commented 4 months ago

I didn't use lvmthin with Talos yet, but we use ZFS, which works perfectly. And traditional LVM when we need a high performance

bernardgut commented 4 months ago

I am doing the same. I wanted to test LVMTHIN because I need velero to work on every storageclass. How did you handle backups for LVM (thick)?

BTW I figured it out: For anyone looking at this thread in the future, You need to load the dm-thin-pool kernel module in machine.kernel.modules (Talos).