siderolabs / sidero

Sidero Metal is a bare metal provisioning system with support for Kubernetes Cluster API.
https://www.sidero.dev
Mozilla Public License 2.0
409 stars 63 forks source link

Dell Precision Misidentified in server data #592

Open edude03 opened 3 years ago

edude03 commented 3 years ago

I was trying to add my dell machines to a serverclass and I noticed when I run kubectl get servers the server information wasn't setup correctly:

- apiVersion: metal.sidero.dev/v1alpha1
  kind: Server
  metadata:
    creationTimestamp: "2021-10-07T02:08:52Z"
    finalizers:
    - storage.finalizers.server.k8s.io
    generation: 2
    name: 4c4c4544-004d-3510-8034-b8c04f315332
    resourceVersion: "366098"
    uid: f574bd1c-69b3-4a13-b7d1-7ed134602416
  spec:
    accepted: true
    configPatches:
    - op: replace
      path: /machine/install/disk
      value: /dev/sda
    cpu:
      manufacturer: Intel(R) Corporation
      version: Intel(R) Xeon(R) W-2135 CPU @ 3.70GHz
    hostname: 192.168.4.155
    system:
      family: Unknown
      manufacturer: Precision
      productName: Dell Inc.
      serialNumber: "0738"
      skuNumber: 8M541S2
      version: Precision 5820 Tower

The Manufacturer should be Dell Inc and the productName should be Precision. I think serial and sku are swapped as well.

It is working on some HP machines I have however:

system:
      family: Unknown
      manufacturer: Hewlett-Packard
      productName: HP ProDesk 600 G1 DM
      serialNumber: Kxxxxxxxx
      skuNumber: 103C_53307F G=D
      version: 2UA5181C7R
rsmitty commented 3 years ago

Hi @edude03, thanks for reporting this. Let us take a look on our side to see if we're swapping values as you say. Be back in touch soon!