siderolabs / talos-cloud-controller-manager

Generic cloud controller manager for hybrid deployments using Talos OS
MIT License
59 stars 11 forks source link

fix: set priorityClassName #166

Closed mrclrchtr closed 5 months ago

mrclrchtr commented 5 months ago

Pull Request

What? (description)

Set missing priorityClassName

Why? (reasoning)

It's missing

Acceptance

Please use the following checklist:

make conformance error:

Error: failed to convert declarations: failed to convert commit policy: 1 error(s) decoding:

* 'gpg' expected a map, got 'bool'
sergelogvinov commented 5 months ago

Hi, thank you for this proposal, bitnami usually uses empty string by default.

https://github.com/bitnami/charts/blob/main/bitnami/postgresql/values.yaml#L574

Maybe we should set like:

priorityClassName: {{ default  "system-cluster-critical" .Values.priorityClassName }}
mrclrchtr commented 5 months ago

Yes, you're absolutely right. I was a bit stressed earlier and made a copy paste mistake.

sergelogvinov commented 5 months ago

Hi, can you:

Thanks.

mrclrchtr commented 5 months ago

Done. Thank you very much, sorry about the circumstances 😅

sergelogvinov commented 5 months ago

/m

sergelogvinov commented 5 months ago

/m

sergelogvinov commented 5 months ago

Thank you!