siderolabs / talos-cloud-controller-manager

Generic cloud controller manager for hybrid deployments using Talos OS
MIT License
52 stars 8 forks source link

Label the node with the Talos configured virtual IP #167

Open nogweii opened 4 months ago

nogweii commented 4 months ago

Feature Request

Basically, implement https://github.com/siderolabs/talos/issues/7166 in Talos-CCM.

Description

It would be handy to have a label that gets moved around as the VIP changes nodes. I'd expect it to only support the built-in vip rather than any other implementation's. I'm not sure how to determine what the VIP is configured to be, though.

sergelogvinov commented 4 months ago

Hi, do you use Talos VIP (float-ip in control plane) for EgressGateway ?

nogweii commented 4 months ago

Nope. My current planned use-case is to dynamically decide which endpoint to use in my shell scripts wrapping talosctl by setting -e to whichever node has the VIP. But not to the VIP itself as per the documentation's recommendation.

sergelogvinov commented 4 months ago

To be honest, i did not get your idea. talosctl get addesses can show you there the VIP (control plane float ip) currently exists. talosctl config can contain multiple IP endpoints, and it will use one that is active (alive).

smira commented 4 months ago

Don't use Talos VIP for Talos API endpoint - it will break, as it depends on etcd quorum, and Talos API access you need all the time.