fix: prepend v to .Chart.AppVersion for image

[kanya-approve]

What?

This is supposed to resolve #96. This will prepend v to the image.

Why?

Helm deployment fails because the "ghcr.io/siderolabs/talos-cloud-controller-manager:1.4.0" image does not exist.

Acceptance

• [x] you linked an issue (if applicable)
• [ ] you included tests (if applicable)
• [x] you ran conformance (make conformance)
• [x] you linted your code (make lint)
• [x] you linted your code (make unit)

[sergelogvinov]

Thank you for your PR. I believe it was human error, than I did release procedure. I think the bast way to solve it in future to add test in github actions .github/workflows/release-pre.yaml.

make docs - knows the release TAG, and it can check the version in Chart.yaml file.

[kanya-approve]

What else should I add?

[sergelogvinov]

What else should I add?

how about this yq -i '.appVersion = "v1.2.3"' charts/talos-cloud-controller-manager/Chart.yaml

It will replace latest tag in Chart.yaml, if we set right version - the Chart.yaml would not change. here .github/workflows/release-pre.yaml we have 'Check' step -> git diff --exit-code

[kanya-approve]

Are you ok with the chart version reflecting as v{ACTUAL_VERSION} vs. ACTUAL_VERSION

[sergelogvinov]

Are you ok with the chart version reflecting as v{ACTUAL_VERSION} vs. ACTUAL_VERSION

Hello, git tag already have v prefix, so I believe the best way to fix this typo is to check proper string in helm.appVersion. Otherwise, we did not fix like this typo in the future... (appVersion == git-tag)

What do you think?

[sergelogvinov]

/m

[sergelogvinov]

/m

[sergelogvinov]

@kanya-approve Thank you.

[sergelogvinov]

/m