search

siderolabs / talos

Talos Linux is a modern Linux distribution built for Kubernetes.
https://www.talos.dev
Mozilla Public License 2.0
6.47k stars 517 forks source link

talosctl: Cordon node on reboot #2162

Closed patatman closed 2 months ago

patatman commented 4 years ago

Feature Request

talosctl reboot would Cordon the node being rebooted.

Description

If talos received a reboot trough the talosctl, it would be nice if that specific node is Cordonned in K8s. This would mean that K8s is aware the node is having maintenance. The question however, wether the node should be uncordonned when it's back online. Or is this something you should do manually?

freswa commented 4 years ago

I agree with cordoning a node on shutdown. But when it's back up again, it should only be uncordoned if explicitly set to do so (e.g. talosctl reboot --auto-uncordon). Sometimes there are hickups after an upgrade and it's pretty nice that you have some time to check the node before it's on duty again.

github-actions[bot] commented 2 months ago

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 2 months ago

This issue was closed because it has been stalled for 7 days with no activity.