search

siderolabs / talos

Talos Linux is a modern Linux distribution built for Kubernetes.
https://www.talos.dev
Mozilla Public License 2.0
5.75k stars 466 forks source link

talosctl gen config does not set cluster.apiServer.certSANs if port is omitted #5536

Closed haslersn closed 2 years ago

haslersn commented 2 years ago

When running

talosctl gen config talos https://example.com

with talosctl v1.0.4, then the generated controlplane.yaml doesn't have cluster.apiServer.certSANs. When adding a port (e.g. talosctl gen config talos https://example.com:6443) then it works.

smira commented 2 years ago

In fact, this shouldn't be needed, as Talos should inject the control plane endpoint hostname automatically as certSAN (there's no need to have it explicitly in the config).