search

siderolabs / talos

Talos Linux is a modern Linux distribution built for Kubernetes.
https://www.talos.dev
Mozilla Public License 2.0
6.05k stars 494 forks source link

Talos member labels #5637

Open smira opened 2 years ago

smira commented 2 years ago

Feature Request

Automatic labels:

User-supplied labels:

Push labels automatically via the kubelet (or without the kubelet) to the Kubernetes Node resource.

Description

This should be pushed through the Cluster Discovery, so that each member can resolve member label queries to a list members.

Timoses commented 2 years ago

Thanks for linking me here @smira. As a Talos novice I don't quite understand the issue description and its relation to #5653.

frezbo commented 2 years ago

the idea is here to use something along the lines of talosctl -l control-plane get links , wehre control-plane a node label assigned outside kubernetes

Timoses commented 2 years ago

the idea is here to use something along the lines of talosctl -l control-plane get links , wehre control-plane a node label assigned outside kubernetes

I like that idea. In regard to https://github.com/siderolabs/talos/issues/5653 a --all flag could then perhaps be read as "target all labels" (though this would be more difficult to interpret: What labels? Only automatic labels? It seems less intuitive than saying "all nodes").

onedr0p commented 4 weeks ago

Could adding support for labeling nodes with talos version and schematic id be in the scope of this request or should I open a new issue? These labels would be helpful in writing automation, especially around a custom controller that could update talos.